Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(scripts): remove deprecated exec abstractions #25569

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Nov 8, 2022

Current Behavior

  • we use abstraction for child_process exec and execSync

New Behavior

  • we don't use abstraction for native nodejs exec calls

Related Issue(s)

Follows #24349

@size-auditor
Copy link

size-auditor bot commented Nov 8, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d1228a137bb5f28014bad869d88584ae95ba46da (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3348dd2:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 8, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1569 1596 5000
Button mount 1124 1149 5000
FluentProvider mount 1903 1892 5000
FluentProviderWithTheme mount 762 761 10
FluentProviderWithTheme virtual-rerender 705 731 10
FluentProviderWithTheme virtual-rerender-with-unmount 737 773 10
MakeStyles mount 2274 2302 50000
SpinButton mount 3037 3059 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 8, 2022

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 193 168 1.15:1
TreeWith60ListItems.default 164 147 1.12:1
VideoMinimalPerf.default 774 709 1.09:1
AnimationMinimalPerf.default 548 507 1.08:1
GridMinimalPerf.default 324 306 1.06:1
ButtonSlotsPerf.default 556 530 1.05:1
ChatMinimalPerf.default 730 695 1.05:1
DialogMinimalPerf.default 786 749 1.05:1
IconMinimalPerf.default 700 669 1.05:1
MenuMinimalPerf.default 841 807 1.04:1
SegmentMinimalPerf.default 336 323 1.04:1
DatepickerMinimalPerf.default 5876 5699 1.03:1
LoaderMinimalPerf.default 341 330 1.03:1
StatusMinimalPerf.default 684 661 1.03:1
TextAreaMinimalPerf.default 470 456 1.03:1
AccordionMinimalPerf.default 134 132 1.02:1
AttachmentMinimalPerf.default 144 141 1.02:1
ButtonMinimalPerf.default 164 160 1.02:1
ButtonOverridesMissPerf.default 1309 1278 1.02:1
DropdownManyItemsPerf.default 649 637 1.02:1
ItemLayoutMinimalPerf.default 1168 1142 1.02:1
ListWith60ListItems.default 604 590 1.02:1
PortalMinimalPerf.default 170 166 1.02:1
TableManyItemsPerf.default 1876 1843 1.02:1
TextMinimalPerf.default 338 333 1.02:1
TooltipMinimalPerf.default 2321 2265 1.02:1
AlertMinimalPerf.default 263 261 1.01:1
FlexMinimalPerf.default 285 282 1.01:1
InputMinimalPerf.default 1144 1130 1.01:1
RosterPerf.default 2139 2113 1.01:1
RefMinimalPerf.default 205 202 1.01:1
TableMinimalPerf.default 385 381 1.01:1
TreeMinimalPerf.default 806 800 1.01:1
AttachmentSlotsPerf.default 1106 1104 1:1
EmbedMinimalPerf.default 3624 3629 1:1
MenuButtonMinimalPerf.default 1687 1690 1:1
ProviderMergeThemesPerf.default 1261 1256 1:1
SkeletonMinimalPerf.default 328 328 1:1
SliderMinimalPerf.default 1572 1572 1:1
SplitButtonMinimalPerf.default 4294 4280 1:1
CarouselMinimalPerf.default 467 471 0.99:1
ChatWithPopoverPerf.default 344 347 0.99:1
CheckboxMinimalPerf.default 2039 2057 0.99:1
LayoutMinimalPerf.default 352 357 0.99:1
ReactionMinimalPerf.default 369 373 0.99:1
CustomToolbarPrototype.default 2656 2673 0.99:1
ToolbarMinimalPerf.default 906 917 0.99:1
ChatDuplicateMessagesPerf.default 263 268 0.98:1
DropdownMinimalPerf.default 2682 2723 0.98:1
LabelMinimalPerf.default 359 366 0.98:1
ListCommonPerf.default 621 634 0.98:1
PopupMinimalPerf.default 627 639 0.98:1
CardMinimalPerf.default 495 512 0.97:1
HeaderMinimalPerf.default 344 355 0.97:1
ListNestedPerf.default 536 552 0.97:1
DividerMinimalPerf.default 340 356 0.96:1
FormMinimalPerf.default 362 376 0.96:1
HeaderSlotsPerf.default 744 779 0.96:1
ListMinimalPerf.default 491 510 0.96:1
RadioGroupMinimalPerf.default 424 442 0.96:1
BoxMinimalPerf.default 317 333 0.95:1
ProviderMinimalPerf.default 398 418 0.95:1
ImageMinimalPerf.default 383 407 0.94:1

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 8, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
3.153 kB
1.299 kB
react-accordion
Accordion (including children components)
79.284 kB
24.446 kB
react-alert
Alert
86.986 kB
21.736 kB
react-avatar
Avatar
51.171 kB
14.313 kB
react-avatar
AvatarGroup
14.996 kB
6.013 kB
react-avatar
AvatarGroupItem
65.749 kB
18.412 kB
react-badge
Badge
22.646 kB
7.228 kB
react-badge
CounterBadge
23.536 kB
7.512 kB
react-badge
PresenceBadge
24.096 kB
7.09 kB
react-button
Button
36.85 kB
9.917 kB
react-button
CompoundButton
43.875 kB
11.134 kB
react-button
MenuButton
41.527 kB
11.19 kB
react-button
SplitButton
48.973 kB
12.592 kB
react-button
ToggleButton
52.675 kB
11.418 kB
react-card
Card - All
71.863 kB
20.939 kB
react-card
Card
67.641 kB
19.897 kB
react-card
CardFooter
8.607 kB
3.622 kB
react-card
CardHeader
9.782 kB
3.998 kB
react-card
CardPreview
8.708 kB
3.678 kB
react-combobox
Combobox (including child components)
78.076 kB
24.991 kB
react-combobox
Dropdown (including child components)
77.363 kB
24.893 kB
react-components
react-components: Button, FluentProvider & webLightTheme
62.941 kB
17.678 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.948 kB
52.993 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-dialog
Dialog (including children components)
83.147 kB
24.799 kB
react-divider
Divider
16.505 kB
5.925 kB
react-image
Image
10.826 kB
4.286 kB
react-infobutton
InfoButton
117.928 kB
35.402 kB
react-input
Input
24.112 kB
7.892 kB
react-label
Label
9.384 kB
3.883 kB
react-link
Link
11.852 kB
4.888 kB
react-menu
Menu (including children components)
117.131 kB
36.2 kB
react-menu
Menu (including selectable components)
120.2 kB
36.726 kB
react-overflow
hooks only
11.004 kB
4.188 kB
react-persona
Persona
56.289 kB
15.712 kB
react-popover
Popover
103.672 kB
31.871 kB
react-portal
Portal
10.495 kB
3.851 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
react-positioning
usePositioning
19.826 kB
7.417 kB
react-progress
Progress
13.526 kB
5.113 kB
react-provider
FluentProvider
15.807 kB
5.909 kB
react-radio
Radio
36.436 kB
12.126 kB
react-radio
RadioGroup
14.294 kB
5.723 kB
react-select
Select
23.428 kB
8.023 kB
react-slider
Slider
32.108 kB
10.195 kB
react-spinbutton
SpinButton
44.42 kB
12.815 kB
react-spinner
Spinner
20.003 kB
6.449 kB
react-switch
Switch
33.443 kB
10.585 kB
react-text
Text - Default
11.828 kB
4.627 kB
react-text
Text - Wrappers
15.138 kB
5.064 kB
react-textarea
Textarea
25.687 kB
8.331 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.65 kB
6.444 kB
react-theme
Teams: Light theme
17.486 kB
5.057 kB
react-tooltip
Tooltip
42.032 kB
14.739 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against d1228a137bb5f28014bad869d88584ae95ba46da

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 8, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1446 1427 5000
Breadcrumb mount 3586 3552 1000
Checkbox mount 3206 3169 5000
CheckboxBase mount 2876 2905 5000
ChoiceGroup mount 5426 5518 5000
ComboBox mount 1517 1487 1000
CommandBar mount 11556 11732 1000
ContextualMenu mount 14601 14286 1000
DefaultButton mount 1618 1703 5000
DetailsRow mount 4413 4307 5000
DetailsRowFast mount 4355 4344 5000
DetailsRowNoStyles mount 4171 4278 5000
Dialog mount 3688 3781 1000
DocumentCardTitle mount 704 711 1000
Dropdown mount 3958 3883 5000
FocusTrapZone mount 2396 2519 5000
FocusZone mount 2335 2339 5000
GroupedList mount 2299 2539 2
GroupedList virtual-rerender 1355 1370 2
GroupedList virtual-rerender-with-unmount 2056 2062 2
GroupedListV2 mount 702 674 2
GroupedListV2 virtual-rerender 656 652 2
GroupedListV2 virtual-rerender-with-unmount 694 685 2
IconButton mount 2250 2300 5000
Label mount 875 897 5000
Layer mount 5302 5200 5000
Link mount 1014 1003 5000
MenuButton mount 2044 2025 5000
MessageBar mount 2778 2799 5000
Nav mount 4193 3947 1000
OverflowSet mount 1607 1588 5000
Panel mount 3082 3082 1000
Persona mount 1533 1533 1000
Pivot mount 1965 2018 1000
PrimaryButton mount 1800 1817 5000
Rating mount 8811 8428 5000
SearchBox mount 1867 1853 5000
Shimmer mount 3471 3499 5000
Slider mount 2593 2539 5000
SpinButton mount 5628 5551 5000
Spinner mount 924 973 5000
SplitButton mount 3749 3820 5000
Stack mount 986 986 5000
StackWithIntrinsicChildren mount 2899 2864 5000
StackWithTextChildren mount 5878 5933 5000
SwatchColorPicker mount 12559 12403 5000
TagPicker mount 3169 3228 5000
TeachingBubble mount 105529 108322 5000
Text mount 951 972 5000
TextField mount 1907 1944 5000
ThemeProvider mount 1878 1848 5000
ThemeProvider virtual-rerender 1313 1321 5000
ThemeProvider virtual-rerender-with-unmount 2635 2611 5000
Toggle mount 1292 1322 5000
buttonNative mount 642 666 5000

@Hotell Hotell marked this pull request as ready for review November 8, 2022 12:49
@Hotell Hotell requested a review from a team as a code owner November 8, 2022 12:49
@tudorpopams tudorpopams self-requested a review November 8, 2022 13:14
@Hotell Hotell force-pushed the hotell/build/scripts/remove-exec branch from 7c25d1d to cce1a41 Compare November 10, 2022 12:24
@Hotell Hotell enabled auto-merge (squash) November 10, 2022 12:24
@Hotell Hotell force-pushed the hotell/build/scripts/remove-exec branch from cce1a41 to 3348dd2 Compare November 10, 2022 17:49
@Hotell Hotell merged commit 63c8aa4 into microsoft:master Nov 10, 2022
@Hotell Hotell deleted the hotell/build/scripts/remove-exec branch November 10, 2022 18:55
sunilsurana added a commit to sunilsurana/fluentuifork1 that referenced this pull request Nov 12, 2022
* stress-test: add "afterframe" dependency (microsoft#25560)

Previously stress-test used a "requestPostAnimationFrame" function that
is used to measure from just before style recalc, layout and paint are
executed to just afterward.

This change drops that function in favor of taking a dependency on
afterframe, a library that does the same thing.

* Fix: Update tabs to remain the same size between unselected and selected states (microsoft#25542)

* Add support to keep tabs from changing size when selected

* Update for naming and tests

* Rename update

* Update packages/react-components/react-tabs/src/components/TabList/TabList.types.ts

Co-authored-by: Sean Monahan <[email protected]>

Co-authored-by: Sean Monahan <[email protected]>

* chore: Add reduced-motion documentation to Spinner (microsoft#25561)

* chore: Add reduced-motion documentation to Spinner

* change file

* chore: Add documentation to Progress about reduced-motion (microsoft#25563)

* chore: Add documentation to Progress about reduced-motion

* change file

* stress-test: disable CSS transitions on injected styles (microsoft#25559)

This addresses an issue where Firefox's style recalculation measurement
becomes unstable when controls under test have CSS transitions.

Specifically, our test injects styles that update the background color
of selected controls and many Fluent controls transition the background
color for different states like "hover" and "focus".

With transitions running Firefox will sometimes include the transition
time in the style recalc measurement and sometimes not. Additionally,
Chromium browsers never include the transition time in the measurement.

Disabling transitions ensures measurement behavior is consistent in
Firefox and in alignment with the behavior of Chromium browsers.

* docs(rfcs): add triage automation rfc (microsoft#24817)

* chore: update beachball ignore list to apply to new project structure (microsoft#25531)

* bugfix(react-switch): adds line-height=0 to switch indicator slot (microsoft#25507)

* chore: add both options to useArrowNavigationGroup (microsoft#25568)

* chore: add both options to useArrowNavigationGroup

* chore: add changes

* chore: update api

* chore(vr-tests-v9): Convert Dialog and Image VR tests to CSF (microsoft#25527)

* chore: toolbar a11y improvements (microsoft#25562)

* feat: create vertical example

* chore: add navigation arrows for vertical scenario

* chore: add labels for all toolbar stories

* chore: update tooltip example

* chore: update radio example

* chore: update toolbar stories examples

* chore: add changes

* chore: use both in toolbar arrow key nav

* chore: update snapshot

* chore(react-dialog): migrate to new package structure (microsoft#25523)

Co-authored-by: Oleksandr Fediashov <[email protected]>

* chore(react-overflow): migrate to new package structure (microsoft#25524)

* Expand @fluentui/react root index file's export *s to uncover and fix duplicate exports. (microsoft#25545)

* expanding index.

* change.

* Replacing with inline deprecation exclusions.

* setting export * to warning.

* change.

* moving rules around.

* fix: v9 form controls with underline should have underline-specific disabled styling (microsoft#25543)

Updates disabled form styling for Input, Select, Spinbutton, Combobox, and Dropdown

* docs(public-docsite-v9): Adding a basic setup section to the SSR docs (microsoft#25564)

* applying package updates

* update regex

* updatE

* Update azure-pipelines.vrt-baseline.yml for Azure Pipelines

* Update azure-pipelines.vrt-baseline.yml for Azure Pipelines

* chore(deps): bump loader-utils from 2.0.0 to 2.0.3 (microsoft#25567)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.0 to 2.0.3.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.3/CHANGELOG.md)
- [Commits](webpack/loader-utils@v2.0.0...v2.0.3)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: migrate @types/node to 14 to align with our supported node version (microsoft#25510)

* chore(deps): resolve only to 1 @types/node version to mitigate global leaks and api-generation errors

* fix(bundle-size): fix type errors exposed by node 14 typings

* fix(tools): fix type errors exposed by node 14 typings

* fix(typings): fix type errors exposed by node 14 typings

* revert:  use resolution for @types/node

* chore(ts-minbar-test-react): use @types/node 14 explicitly

* generate changefiles

* chore: dedupe deps

* fix(scripts): fix type errors exposed by node 14 typings

* test: replace deprecated module.parent with require.main within isConformance

* generate changefiles

* test(react): clean up persona-coin test and use isConformant without side-effects

* fix(storybook): fix theme picker current selection (microsoft#25533)

* update

* chore(vr-tests-v9): Convert Accordion VR tests to CSF (microsoft#25525)

* fix: Update Avatar active ring color to match base color (microsoft#25497)

* RFC: Field Package Layout (microsoft#25380)

* Feature: Added large tab size to react-tabs (microsoft#25577)

* Added large tab size

* yarn change

* Update vr-tests

* Code review fix

* feat(react-infobutton): Adding size prop, HCM styles, and updating styles to match design spec (microsoft#25519)

* updating styles and adding size prop

* updating comment

* adding requested changes

* fix: Adding expanded styles for MenuButtons and making various other styling fixes for Button components (microsoft#25521)

* fix: Adding expanded styles for MenuButtons and making various other styling fixes for Button components.

* Adding change file.

* Addressing PR feedback.

Co-authored-by: KHMakoto <[email protected]>

* chore: Clean up Field tests and story imports in preparation of moving to individual packages (microsoft#25594)

* Remove custom `isConformant` function for Field tests, and instead inline the customizations in each call to `isConformant`
* Disable the `exported-top-level` test because the components will be exported as e.g. `InputField_unstable` from the component packages.
* Change the stories to import from `@fluentui/react-components/unstable`, instead of the individual package.
* Rename the `FieldComponent` type to `FieldControl` to correspond to the `control` slot name.

* Tabs icon toggle (microsoft#25597)

* Added regular filled icon toggling

* yarn change

* chore: Refactor Field components into the base component's package (microsoft#25593)

Move Field components into their respective packages, as discussed in RFC microsoft#25380

* Update Component Implementation Epic template (microsoft#25480)

* update to use vrscreenshotdiff beta

* change lock file

* update package version

* applying package updates

* update pr pipeline to add v8

* PR to add tasks in pipeline for v9 VRT integration (microsoft#25606)

* fix: create valid export maps (microsoft#25558)

* generate changefiles

* chore(deps): bump socket.io-parser from 4.0.4 to 4.0.5 (microsoft#25604)

Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](socketio/socket.io-parser@4.0.4...4.0.5)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(react-dialog): removes unnecessary union case for DialogOpenChangeData (microsoft#25504)

* templatize

* update

* templatize

* updatE

* refactor(scripts): remove deprecated exec abstractions (microsoft#25569)

* fix(scripts): make eslint run again on pre-commit (microsoft#25537)

* feat(react-components): Move AvatarGroup to stable (microsoft#25005)

* update

* update version

* run partial tests

* update

* update

* update

* update

* update

* update

* updatE

* updatE

* update version

* update lock file

* update name

* update version

* add quotes

* docs: refactor Text documentation and add missing guidance for presets/alignment (microsoft#25587)

Fixes microsoft#24341
Fixes microsoft#25548

* update

* package version

* fix(react-menu): remove unwanted aria attributes on context menu (microsoft#25615)

* fix(react-menu): remove unwanted aria attributes on context menu

* chore: updates trigger selector for cypress tests

* remove unwanted param

* update

* applying package updates

* convert

* checkpoint

* add regex

* change convert script

* updates

* update sw version

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Sean Monahan <[email protected]>
Co-authored-by: Geoff Cox (Microsoft) <[email protected]>
Co-authored-by: tomi-msft <[email protected]>
Co-authored-by: Martin Hochel <[email protected]>
Co-authored-by: Bernardo Sunderhus <[email protected]>
Co-authored-by: chajun <[email protected]>
Co-authored-by: Tristan Watanabe <[email protected]>
Co-authored-by: Oleksandr Fediashov <[email protected]>
Co-authored-by: David Zearing <[email protected]>
Co-authored-by: Sarah Higley <[email protected]>
Co-authored-by: Esteban Munoz Facusse <[email protected]>
Co-authored-by: Fluent UI Build <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tudor Popa <[email protected]>
Co-authored-by: Ben Howell <[email protected]>
Co-authored-by: Makoto Morimoto <[email protected]>
Co-authored-by: KHMakoto <[email protected]>
Co-authored-by: Marcos Moura <[email protected]>
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants